BUG: raise TypeError when array not like 1D in pandas.array #63173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@rhshadrach @Alvaro-Kothe |
Comment on lines
+325
to
+328
| if dtype == StringDtype() and isinstance(data, (list, tuple)): | ||
| for i in data: | ||
| if isinstance(i, (list, tuple, np.ndarray)): | ||
| raise TypeError("Values must be a 1D list-like") |
Member
There was a problem hiding this comment.
This check seems extremely expensive for an edge case. Maybe it's possible to patch the function that performs the conversion in _from_sequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas.arrayworks fine when 2-D array contains string #63112It follows from #63058